Repository navigation
test: real-file journeys for Particles and EDS per-region composition - #100
Merged
Merged
Conversation
…-region composition ParticlesRealFileJourney opens each Ceta TIFF/EMD in data/tem (17.5 kx to 1.05 Mx), shows objects, attaches the counts, size and density lines, opens the object table and exports the CSV into --export-dir. EDXRegionsRealFileJourney opens the 1339, 1840 and 1456 Velox spectrum images, quantifies the whole map, draws two regions through the room's keyboard route, quantifies each and exports the results. Both are opt-in (MACTEM_REAL_DATA=1) and find the data through $MACEM_DATA. Done: the precipitation workflow's macTEM half is driven on the real files; next: re-run after #98 and MacEMUI#69 land. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul
Two opt-in UI journeys that drive macTEM's half of the precipitation analysis on Paul's own data. Both skip unless
MACTEM_REAL_DATA=1, and they find the files through$MACEM_DATA(default../data). No data is committed.ParticlesRealFileJourney covers seven Ceta images: the 1305, 1306 and 1309 TIFFs, the 1309 EMD, and the HRTEM 630 kx and 1.05 Mx TIFFs. On each it opens the file in the Image room, runs Show Objects with the default settings, and attaches the counts, size and density lines. It then opens the Object Table (only when there are 2000 counted objects or fewer) and runs Export CSV into
--export-dir. Counts are attached, not asserted, because there is no truth for these files yet.On the HRTEM images the default threshold picks out the lattice, giving 9,000 to 37,000 objects. One XCUITest snapshot of a table that size builds every row, and that keeps the main thread busy past XCUITest's 30 s limit (spindump:
NSTableView viewAtColumn:row:makeIfNecessary:). The journey therefore skips the table step there. A person scrolling the table only builds the rows in view, so this is not shown to be a user-facing hang.EDXRegionsRealFileJourney covers the 1339, 1840 and 1456 spectrum images. On each it quantifies the whole map, draws Region 1 (rectangle) and Region 2 (ellipse), quantifies each, checks the region table and exports Results CSV. XCUITest's clicks and drags do not reach the drawing layer's gestures, which
EDXJourneyalready notes, so the regions are drawn through the room's keyboard route: click the colour mix, then press Return.State on
maintoday.--export-dir, issue polish: Particles Export CSV ignores --export-dir and drops its result #94). With fix: Particles Export CSV writes into --export-dir and reports its result #98 checked out locally, the export steps pass on the 1305 TIFF, the 1309 EMD and the 1631 HRTEM TIFF.Results · Regionuntil fix: the EDS results header and exports name the kept region MacEMUI#69 lands and macTEM resolves that MacEMUI version (issue polish: EDS results header and exports name every region "Region", so region exports overwrite each other #99). With the header check loosened, the 1339 file passes end to end: whole map, Region 1, Region 2, region table and export.Not numeric. Test-only.
🤖 Generated with Claude Code