Repository navigation
test: EELS Align journey reads the ZLP shift where the app shows it - #117
Merged
Merged
Conversation
testRunAlignsAndKeepsThePlantedHalf hovered the t/λ map and waited for "ZLP shift" in the status line, the old all-maps readout. Since #96 the line names the hovered map only, as the EDS room's, and the demo's shift is flat (no tile beside t/λ), so the wait could never pass. The journey now reads the Processing line ("already aligned in the file, max |shift| 0 eV") and hovers the ZLP shift map on the Maps control's ZLP segment. It checks that macTEM is frontmost before each click (requireFrontmost moves from DemoDataJourney into Journey). Done: EELSJourney 3/3 green on the demo fixture. Next: Paul merges after CI. Fixes #116 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul
Fixes #116.
Cause.
EELSJourney.testRunAlignsAndKeepsThePlantedHalfhovered the t/λ map and waited for "ZLP shift" in the status line. That was the old all-maps readout. Since #96 the status line names the hovered map only, the same way the EDS room does (EELSRoomFormat.tileReadout). On the demo the shift is flat, so no ZLP shift tile is drawn beside t/λ either. The app is right: nothing overwrites a status message. The line the journey read is the hover readout, and Align ran ("Align current").Fix (journey only, no app or MacEMUI change).
requireFrontmost()moves fromDemoDataJourneyintoJourney, and this journey calls it before each click.Before / after. On main the journey fails twice in a row at the ZLP shift wait. On this branch
tools/run-tests.sh ui EELSJourneypasses all 3 journeys (real-data env set, demo fixture).🤖 Generated with Claude Code