Skip to content

Add callback to .complete() #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
typpo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add callback to .complete() #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/assets/javascripts/client/index.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class @Abba
@useVariant(variant)
this

complete: (name) =>
complete: (name, callback) =>
# Optionally pass a name, or read from the cookie
name or= @getVariantCookie()
return this unless name
Expand All @@ -144,7 +144,7 @@ class @Abba
else
@reset()

@recordComplete(name)
@recordComplete(name, callback)
this

reset: =>
Expand Down Expand Up @@ -174,9 +174,9 @@ class @Abba
# Set the variant we chose as a cookie
@setVariantCookie(variant.name)

recordComplete: (name) =>
recordComplete: (name, callback) =>
# Record the experiment was completed on the server
request("#{@endpoint}/complete", experiment: @name, variant: name)
request("#{@endpoint}/complete", experiment: @name, variant: name, callback)

# Variant Cookie

Expand Down