Missing TaskModifier and TaskFactory type definitions in v5

[jrmlt]

In v4, there was no issue using registerModifier with TypeScript. In v5, however, types are no longer correctly inferred.

v4	v5

It can also be seen in this example snippet:

ember-concurrency/packages/test-app/app/task-modifiers/benchmark.js

Line 5 in eb011b0

function benchmarkModifier(taskFactory, option) {

When using TypeScript, the type of the taskFactory is not inferred, and properties like name, taskDefinition, or setTaskDefinition are not recognized.

[ef4]

I hit this too. The problem is clearer if you don't skipLibCheck:

node_modules/.pnpm/ember-concurrency@5.2.0_@babel+core@7.29.0_@glint+template@1.7.7/node_modules/ember-concurrency/declarations/index.d.ts:418:15 - error TS2304: Cannot find name 'TaskModifier'.

418   definition: TaskModifier<any, any[]>,
                  ~~~~~~~~~~~~

node_modules/.pnpm/ember-concurrency@5.2.0_@babel+core@7.29.0_@glint+template@1.7.7/node_modules/ember-concurrency/declarations/index.d.ts:426:4 - error TS2304: Cannot find name 'TaskModifier'.

426 ): TaskModifier<unknown, unknown[]> | null;
       ~~~~~~~~~~~~


Found 2 errors in the same file, starting at: node_modules/.pnpm/ember-concurrency@5.2.0_@babel+core@7.29.0_@glint+template@1.7.7/node_modules/ember-concurrency/declarations/index.d.ts:418

ember-concurrency is publishing a d.ts with an undefined name in it (TaskModifier).