Fix test-app builds against ember-source 7.x - #614
Merged
Merged
Conversation
ember-source 7 no longer exposes the classic `paths`/`absolutePaths` metadata or the `ember` module, which crashed ember-cli 6.x and several older addons in the ember-release, ember-beta and ember-canary scenarios. - ember-cli ^7.2.0, ember-cli-htmlbars ^7.0.1, ember-cli-babel ^8.3.2 - ember-auto-import ^2.13.1 (plus @glimmer/tracking devDep, which ember-auto-import >= 2.11.1 needs to resolve on pre-7 ember-source) - ember-resolver, ember-load-initializers, ember-cli-app-version, ember-qunit, @ember/test-helpers, ember-cli-fastboot bumped to versions that don't import `ember` or `inject` from @ember/service - pnpm overrides for ember-cli-htmlbars and @ember/test-waiters, since ember-prism, ember-code-snippet and tracked-built-ins pull in old ones Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on master started failing in
ember-release,ember-release-with-coverage,ember-betaandember-canarywith:The root cause is that ember-source 7.x (release is now 7.3) no longer exposes the classic
paths/absolutePathsaddon metadata or theembermodule. ember-cli 6.x and several older addons in the test-app rely on those.Changes (test-app only, no changes to the published addon)
ember-cli^7.2.0,ember-cli-htmlbars^7.0.1,ember-cli-babel^8.3.2: these handle ember-source withoutpaths.ember-auto-import^2.13.1, plus@glimmer/trackingas a devDependency. ember-auto-import >= 2.11.1 throws "unable to resolve package @glimmer/tracking" on pre-7 ember-source if the package isn't installed.ember-resolver^13,ember-load-initializers^3,ember-cli-app-version^7,ember-qunit^9.1,@ember/test-helpers^5.4.3,ember-cli-fastboot^6: newer versions that don't importemberorinjectfrom@ember/service, both removed in Ember 7.pnpm.overridesforember-cli-htmlbarsand@ember/test-waiters:ember-prism,ember-code-snippetandtracked-built-inspull in old versions that crash on Ember 7.Verified locally
ember-beta: 132 pass, 0 failThe rest of the scenario matrix hasn't run yet; this PR's CI covers it.
🤖 Generated with Claude Code