Stop privileged workflows from checking out artifact-selected SHAs - #1
Closed
etsauer wants to merge 1 commit into
Closed
Stop privileged workflows from checking out artifact-selected SHAs#1etsauer wants to merge 1 commit into
etsauer wants to merge 1 commit into
Conversation
Fork PRs could place an arbitrary fork-network SHA in the producer artifact and bypass actions/checkout's unsafe-checkout guard. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Closing: this targeted the wrong upstream. The fix is in dora-metrics#1248 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
related to Red Hat PSIRTSUPT-22553 / BOOST-VPD-2026-044
Description
Privileged
workflow_runjobs intest-images.ymlandintegration-tests.ymlchecked out whatever SHA the untrusted producer artifact supplied asbranch_ref. A fork pull request can put a different fork-network commit in that artifact and bypassactions/checkout's unsafe-checkout guard, then run with Quay and other secrets.These consumers now check out
github.event.workflow_run.head_sha, skip unless the triggering repository is this repo, and disable persisted git credentials after checkout.Testing Instructions
workflow_runhead SHA (notbranch_reffrom the artifact).head_repositorycondition).Made with Cursor