Skip to content

Add dark mode to venue map - #26

Merged
pranavgundu merged 1 commit into
mainfrom
codex/dark-mode-map
Aug 16, 2026
Merged

Add dark mode to venue map#26
pranavgundu merged 1 commit into
mainfrom
codex/dark-mode-map

Conversation

@soccer1902

@soccer1902 soccer1902 commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

added dark map in darkmode

Summary by CodeRabbit

  • New Features

    • Added dark-theme support for venue maps, including map controls, popups, borders, and attribution.
    • Map tiles now automatically switch between light and dark styles when the app theme changes.
  • Bug Fixes

    • Improved map readability and visual consistency in dark mode.

@soccer1902
soccer1902 force-pushed the codex/dark-mode-map branch from af003a2 to 5b5ff73 Compare August 16, 2026 10:48
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying coding-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5b5ff73
Status: ✅  Deploy successful!
Preview URL: https://1693b4b4.coding-website-7wo.pages.dev
Branch Preview URL: https://codex-dark-mode-map.coding-website-7wo.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c880bf0-9c06-430d-bb5f-60f31bbc1df7

📥 Commits

Reviewing files that changed from the base of the PR and between 5de00e3 and 5b5ff73.

📒 Files selected for processing (2)
  • src/features/home/VenueMap.module.css
  • src/features/home/VenueMap.tsx

Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The venue map now selects Carto tiles from the document theme, updates its tile layer when the theme changes, cleans up the observer, and applies dark-theme Leaflet control, popup, border, hover, and attribution styles.

Changes

Venue Map Theme Support

Layer / File(s) Summary
Theme-aware tile lifecycle
src/features/home/VenueMap.tsx
VenueMap selects light or dark Carto tiles, updates the existing tile layer when data-theme changes, and disconnects the MutationObserver during cleanup.
Dark-theme Leaflet styling
src/features/home/VenueMap.module.css
The map styles define dark-theme colors, borders, hover states, popup styles, and attribution link styles.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 5b5ff

This localized change adds dark-mode styling to the venue map, and no actionable merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant document
  participant MutationObserver
  participant VenueMap
  participant LeafletTileLayer
  document->>MutationObserver: change data-theme
  MutationObserver->>VenueMap: notify theme mutation
  VenueMap->>LeafletTileLayer: setUrl(theme-specific Carto URL)
  VenueMap->>MutationObserver: disconnect on cleanup
Loading

Suggested reviewers: pranavgundu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding dark mode support to the venue map.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/dark-mode-map

Comment @coderabbitai help to get the list of available commands.

@soccer1902
soccer1902 requested a review from pranavgundu August 16, 2026 10:51

@pranavgundu pranavgundu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pranavgundu
pranavgundu merged commit a3ff442 into main Aug 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants