feat(token): detect internal users proxying as a client - #33
Merged
Conversation
Assembly tokens can carry both internalUserId and clientId when an internal user proxies as a client from the CRM. Both isClientUser and isInternalUser return true in that case, so a plain if/else on either one silently picks a branch based on ordering. isProxying makes the case nameable. Also corrects the README claim that isClientUser requires companyId. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assembly tokens can carry both
internalUserIdandclientIdwhen an internal user previews as a client from the CRM. Today bothisClientUserandisInternalUserreturntrueand bothensureIs*guards pass, soif (token.isInternalUser) {...} else {...}picks a branch by ordering rather than intent — an app can show the admin surface to a proxied client session, or the client view to a real IU. This addstoken.isProxyingso the case is nameable.API calls are unaffected: the SDK never reads identity from the token, the compound key is unchanged, and the backend resolves proxy permissions.
What to look at:
src/token/assembly-token.ts— the new getter only;isClientUser/isInternalUser/ensureIs*semantics are deliberately unchanged, since both identities genuinely are present. Whether a proxy session should count as internal for a given guard is app policy.README.md—isClientUserwas documented as requiringcompanyId; it only checksclientId.Verified:
bun run test(195 pass) andvp checkclean, including a newPROXY_TOKENfixture covering the dual-ID payload end to end through decrypt + validate. Not verified against a real CRM-issued proxy token — the fixture is SDK-encrypted, so field names are assumed to match production.🤖 Generated with Claude Code