ci: stop committing the version bump back to main - #35
Closed
priosshrsth wants to merge 1 commit into
Closed
Conversation
The release job pushed a bump commit to main, which the branch rulesets rejected: PR required, verified signatures required, and code scanning pending. A runner's `git commit` is unsigned regardless of GITHUB_TOKEN — GitHub only signs commits made through its API or web UI — and there are no bypass actors on either ruleset, so the push could not succeed. The version is now applied to package.json and src/version.ts in the runner only, so the published artifact carries the released version while the repository stays untouched. Job permissions drop to contents: read.
Collaborator
Author
|
Superseded by the release-please approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run 32136394717 failed pushing
chore: release v3.0.0to main. Three rules rejected it at once:The commit was unsigned because a runner's
git commitis always unsigned —GITHUB_TOKENauthenticates the push, it does not sign — and GitHub only auto-signs commits made through its API or web UI. Signing alone would not have helped:pull_request,required_linear_history,code_scanning,code_qualityandcopilot_code_revieware all on main, and neither ruleset has a bypass actor. CI cannot write to that branch.So it no longer tries. The version from the release tag is applied to
package.jsonandsrc/version.tsin the runner only; the published artifact carries the right version and nothing is committed back. Permissions drop tocontents: read.What to look at:
.claude/CLAUDE.md— the tradeoff this accepts:versioninpackage.jsonon main is now a placeholder that lags npm.tests/version.test.tskeeps it consistent withsrc/version.ts, but reflecting the real published version means bumping both in a normal PR.Verified:
bun run test(196 pass),vp checkclean, workflow YAML parses. Re-running the failed v3.0.0 job after merge is the real test.🤖 Generated with Claude Code