feat: Reactivity System Improvements & Test Coverage#64
Merged
Conversation
bitencode
approved these changes
Dec 18, 2025
Collaborator
bitencode
left a comment
There was a problem hiding this comment.
Looks good to me - I looked at code changes and briefly scanned tests and doc changes. Don't have a good way to test this other then unit tests, so I'm assuming (a bit) that it's good. 😉
Give my regards and thanks to Claude for help with JSDoc, examples and unit tests 😂
Thank you - it does look safer and possibly more performant 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude
This PR adds a CLAUDE.md file, and claude helped find and fix some defects, performance issues, and added map/set support.
Bug Fixes
Scheduler Error Recovery
Problem: If a scheduled task threw an error, the scheduler's
SCHEDULER_IDwas never reset, preventing all future tasks from being scheduled.Solution: Added proper error handling with try/catch around individual tasks and a finally block to always reset the scheduler state:
Code Improvements
Consolidated Type Detection
Test Coverage Added
New Test Files
Extended Existing Tests
observer.spec.ts
reactive.spec.ts
scheduler.spec.ts
Total: 295 tests (all passing)
Performance Implications