fix: Vue3 reactivity for Set/Map collections#66
Merged
Conversation
When Vue directly accesses a Set/Map (e.g., [...store.numbers]), Vue tracks Symbol.iterator. When the collection is modified via add() or set(), onSet was only notifying on the method name and undefined. Vue wasn't listening on those keys, so it didn't re-render. The fix tracks which iteration keys Vue has accessed per target, and only notifies those specific keys when keysChanged is true. This is more efficient than notifying all possible iteration keys. Also adds comprehensive test coverage for nested Set/Map reactivity: - observer_nested_collections.spec.ts (35 tests) - decorateNestedCollections.spec.ts (34 tests) - testVueCollections.ts (32 Vue3-specific tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Vue directly accesses a Set/Map (e.g., [...store.numbers]), Vue tracks Symbol.iterator. When the collection is modified via add() or set(), onSet was only notifying on the method name and undefined. Vue wasn't listening on those keys, so it didn't re-render.
The fix tracks which iteration keys Vue has accessed per target, and only notifies those specific keys when keysChanged is true. This is more efficient than notifying all possible iteration keys.
Also adds comprehensive test coverage for nested Set/Map reactivity:
🤖 Generated with Claude Code
📚 Bookkeeping:
Testing (if applicable):
Checklist
CHANGELOG.md