fix(vue3): Set.delete() not triggering Vue computed updates#68
Merged
Conversation
Fixed two issues in the Vue 3 integration's onDelete handler: 1. The handler was clearing all reactive mappings for the target after a Set.delete(), which broke subsequent notifications since Vue was tracking the old mappings. 2. The handler wasn't notifying Vue about tracked iteration keys (Symbol.iterator, etc.) when keysChanged was true, unlike onSet. This caused Vue computed properties that used Array.from(set) or spread operators to not react when items were deleted from Sets returned by methods. Added test cases covering: - Vue computed iterating Set returned from method - Set.delete via double indirection through Map lookup 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed two issues in the Vue 3 integration's onDelete handler:
The handler was clearing all reactive mappings for the target after a Set.delete(), which broke subsequent notifications since Vue was tracking the old mappings.
The handler wasn't notifying Vue about tracked iteration keys (Symbol.iterator, etc.) when keysChanged was true, unlike onSet.
This caused Vue computed properties that used Array.from(set) or spread operators to not react when items were deleted from Sets returned by methods.
Added test cases covering:
🤖 Generated with Claude Code