Skip to content

time: fix usec left uninitialized in operator>>= when microsecond fie…#46

Open
heitbaum wants to merge 1 commit into
maekitalo:masterfrom
heitbaum:patch-1
Open

time: fix usec left uninitialized in operator>>= when microsecond fie…#46
heitbaum wants to merge 1 commit into
maekitalo:masterfrom
heitbaum:patch-1

Conversation

@heitbaum

Copy link
Copy Markdown
Contributor

…ld absent

Fixes:

[91/189] Building CXX object src/CMakeFiles/cxxtools.dir/time.cpp.o In file included from ../src/time.cpp:30:
In member function 'void cxxtools::Time::set(unsigned int, unsigned int, unsigned int, unsigned int, unsigned int)',
    inlined from 'void cxxtools::operator>>=(const SerializationInfo&, Time&)' at ../src/time.cpp:365:17:
../include/cxxtools/time.h:177:105: warning: 'usec' may be used uninitialized [-Wmaybe-uninitialized]
  177 |             _usecs = (((((static_cast<uint64_t>(hour) * 60 + min) * 60) + sec) * 1000) + msec) * 1000 + usec;
      |                                                                                                         ^~~~
../src/time.cpp: In function 'void cxxtools::operator>>=(const SerializationInfo&, Time&)':
../src/time.cpp:337:46: note: 'usec' was declared here
  337 |         unsigned short hour, min, sec, msec, usec;
      |                                              ^~~~

…ld absent

Fixes: 
[91/189] Building CXX object src/CMakeFiles/cxxtools.dir/time.cpp.o
In file included from ../src/time.cpp:30:
In member function 'void cxxtools::Time::set(unsigned int, unsigned int, unsigned int, unsigned int, unsigned int)',
    inlined from 'void cxxtools::operator>>=(const SerializationInfo&, Time&)' at ../src/time.cpp:365:17:
../include/cxxtools/time.h:177:105: warning: 'usec' may be used uninitialized [-Wmaybe-uninitialized]
  177 |             _usecs = (((((static_cast<uint64_t>(hour) * 60 + min) * 60) + sec) * 1000) + msec) * 1000 + usec;
      |                                                                                                         ^~~~
../src/time.cpp: In function 'void cxxtools::operator>>=(const SerializationInfo&, Time&)':
../src/time.cpp:337:46: note: 'usec' was declared here
  337 |         unsigned short hour, min, sec, msec, usec;
      |                                              ^~~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant