Skip to content

fix(infra): restrict overly permissive security group ingress #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hacktron-app-stg wants to merge 1 commit into
base: add-terraform-infra
Choose a base branch
from
Open

fix(infra): restrict overly permissive security group ingress #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions infra.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ resource "aws_s3_bucket_public_access_block" "backups" {
restrict_public_buckets = false
}

# VULN 2: Security group open to the entire internet on every port (incl. SSH).
# Security group scoped to HTTPS from within the private network only.
resource "aws_security_group" "open" {
name = "allow-all"
name = "restricted-ingress"

ingress {
from_port = 0
to_port = 65535
protocol = "-1"
cidr_blocks = ["0.0.0.0/0"]
from_port = 443
to_port = 443
protocol = "tcp"
cidr_blocks = ["10.0.0.0/8"]
}
}

Expand Down