fix(infra): harden prod RDS instance — disable public access, encrypt at rest, remove hardcoded password - #123
Open
hacktron-app-stg[bot] wants to merge 1 commit into
Open
Conversation
Disable public accessibility and enable storage encryption on aws_db_instance.prod, and replace the hardcoded master password with a sensitive db_password input variable so the secret is no longer stored in source control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability
infra.tfdefined the production RDS instanceaws_db_instance.prodwith:publicly_accessible = true— the database is reachable from the public internet.storage_encrypted = false— data at rest is unencrypted.password = "SuperSecret123!"— a hardcoded master credential committed to source.Together these let any internet-facing attacker connect to and compromise the database using credentials that are visible in version control.
Fix
publicly_accessible = falseso the instance is no longer exposed to the internet.storage_encrypted = trueto encrypt data at rest.sensitiveinput variabledb_passwordand reference it viavar.db_password, removing the literal secret from source. The value must be supplied out-of-band (e.g.TF_VAR_db_passwordor a secrets manager).Verification
infra.tfand confirmed the change is scoped to theprodRDS resource plus the supporting variable declaration.terraformis not available in the sandbox, soterraform validate/fmtcould not be run; the change is standard HCL and preserves the file's existing style.Automated fix by Hacktron for finding: https://staging.hacktron.ai/testestesttest/findings/f8705a60-6184-4c64-8b1b-2dad7c4f4ea4