Feature/increment25#27
Open
maffka123 wants to merge 5 commits into
Open
Conversation
underbek
approved these changes
Apr 18, 2022
Collaborator
underbek
left a comment
underbek
left a comment
There was a problem hiding this comment.
Насчет таймаута тестов отписал авторам. Дам знать, как пофиксят.
По коду замечаний нет. Все по делу)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vet tests падают потому что версия у них старая, я писала ою этом в слаке
https://yandex-students.slack.com/archives/C034Z1GMKLG/p1650192179631999
Девопс потому что мои уни тесты превышают лимит по времени (я добавила один тест к grpc)