Skip to content

fix prototype pollution caused by a malicious csv file #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chluo1997 wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −1
Open

fix prototype pollution caused by a malicious csv file #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ const defaults = {
strict: false,
outputByteOffset: false
}
const DANGEROUS_KEYS = new Set(['__proto__', 'constructor', 'prototype'])

function sanitizeHeader (header) {
if (DANGEROUS_KEYS.has(header)) {
return null
}
return header
}

class CsvParser extends Transform {
constructor (opts = {}) {
Expand Down Expand Up @@ -155,7 +163,11 @@ class CsvParser extends Transform {

if (this.state.first && !skip) {
this.state.first = false
this.headers = cells.map((header, index) => mapHeaders({ header, index }))
// this.headers = cells.map((header, index) => mapHeaders({ header, index }))
this.headers = cells.map((header, index) => {
const mapped = mapHeaders({ header, index })
return mapped === null ? null : sanitizeHeader(mapped)
}

this.emit('headers', this.headers)
return
Expand Down