Curs1 cc2#9
Open
sebapitur wants to merge 3 commits into
Open
Conversation
magdamiu
reviewed
Jul 6, 2021
magdamiu
left a comment
magdamiu
left a comment
Owner
There was a problem hiding this comment.
Please check the added comments and if something is not clear, just let me know.
| super.onCreate(savedInstanceState); | ||
| setContentView(R.layout.activity_main); | ||
| try { | ||
| String null_ = null; |
Owner
There was a problem hiding this comment.
What is the purpose of this code?
| @@ -54,7 +54,6 @@ public void displayGreetingsOnClick(View view) { | |||
| textViewGreetings.setText(inputName); | |||
| } else { | |||
| editTextName.setError(getString(R.string.error_insert_name)); | |||
Owner
There was a problem hiding this comment.
It is a good practice to format the code with CTRL + ALT + L before you commit it and to remove the unnecessary spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.