Skip to content

[WIP] Develop test branch#435

Open
RuslanKostiv1 wants to merge 2 commits into
magento:mainfrom
RuslanKostiv1:develop-test-branch
Open

[WIP] Develop test branch#435
RuslanKostiv1 wants to merge 2 commits into
magento:mainfrom
RuslanKostiv1:develop-test-branch

Conversation

@RuslanKostiv1
Copy link
Copy Markdown
Contributor

@RuslanKostiv1 RuslanKostiv1 commented Nov 17, 2020

Description (*)

Related Pull Requests

magento/commerce-data-export#13

Fixed Issues (if relevant)

  1. Fixes magento/catalog-storefront#<issue_number>

Questions or comments

Code Review Checklist (*)

See detailed checklist

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
    • expected results in test verified with data from fixture
  • no backward incompatible changes
  • Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
    • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
    • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
  • Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
    • Check composer.json dependencies
  • Legacy code is deleted
    • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
    • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
    • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
    • Any “mapper” on Message Broker (between Export API and SF API)
      • if mapper still needed, verify fields used in mapping, remove not relevant fields

@RuslanKostiv1
Copy link
Copy Markdown
Contributor Author

@magento run all tests

@RuslanKostiv1
Copy link
Copy Markdown
Contributor Author

@magento run all tests

Base automatically changed from develop to main February 8, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant