Skip to content

Modified the PR template to include README.md update reqirement if ne…#8

Open
bgorski wants to merge 1 commit into
magento:mainfrom
bgorski:inclusion-of-checklist-in-pr-template
Open

Modified the PR template to include README.md update reqirement if ne…#8
bgorski wants to merge 1 commit into
magento:mainfrom
bgorski:inclusion-of-checklist-in-pr-template

Conversation

@bgorski
Copy link
Copy Markdown

@bgorski bgorski commented Apr 2, 2021

…cessary

Description (*)

With the introduction of the README.md template, there is a requirement of describing module installation, structure and extension points in the readme.
We need to pay special attention to README.md always being up to date, because an outdated readme can do more harm than good. This is why all code contributors need to be aware that they are supposed to modify README.md as well when they create modifications that affect any of readme predefined sections.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/catalog-storefront#<issue_number>

Questions or comments

Code Review Checklist (*)

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
  • no backward incompatible changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant