Make missing swatches modal reappear

[jtomaszewski]

Currently it appears only once. If user closes the modal and clicks "Add to cart" again, the modal doesn't appear again.

Besides fixing that, I also did two fixes:

• make the "overlay" clickable, so user can easily go back to product details screen
• hide the error message - it isn't really needed, when the modal is shown anyways [when no required swatch is selected]

[msiewierska]

Hi @jtomaszewski Thank you a lot for your contribution.

modal appears only once It was done on purpose that the missing swatches modal appears only once. It seems to us that it is quite a corner case that a user does not check any swatch even on the modal. Error message stays in this case in the buybox. Do you think that showing modal more times could increase UX?

hide the error message - we cannot just hide error message for all cases because missing swatches modal is just an option - it is turned on by default but the case with standard error messages and no modal should also be supported.

Please rebase your PR and remove css part.

[jtomaszewski]

Error message stays in this case in the buybox. Do you think that showing modal more times could increase UX?

I think it's better for it to be consistent (why would it react differently on the 2nd click)? error messages are not always that clearly visible to the user if they are seen after a page redirect in some buybox.