Bump to v1.1.2 #10
Bump to v1.1.2 #10
Conversation
Fix/issue 8 csv import
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| const text = await file.text() | ||
| const rows = parseCsv(text) | ||
| if (rows.length === 0) throw new Error("CSV_EMPTY") | ||
| const header = rows[0] | ||
| if ( | ||
| header.length !== CSV_HEADERS.length || | ||
| !header.every((h, i) => h === CSV_HEADERS[i]) | ||
| ) { | ||
| throw new Error("CSV_HEADER_MISMATCH") |
There was a problem hiding this comment.
[P1] Strip BOM before validating CSV headers
The new prepareCsvForUpload rejects any CSV whose header array does not exactly match CSV_HEADERS. parseCsv leaves UTF‑8 BOM characters intact, so a file saved by Excel or other editors that emit a BOM yields a first header value of "\ufeffdate". The subsequent equality check throws CSV_HEADER_MISMATCH and aborts the import even though the column names are otherwise correct and were previously accepted. Removing the BOM before comparing (or trimming the header values) avoids breaking imports for BOM-encoded CSV files.
Useful? React with 👍 / 👎.
1 participant
変更内容
Closes #8