update: improve build of nitro #14
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| # 余計なプラットフォーム用の optional を入れない（任意） | ||
| supportedArchitectures: | ||
| os: | ||
| - win32 | ||
| cpu: | ||
| - x64 |
There was a problem hiding this comment.
[P1] Limiting optional binaries to win32 breaks non‑Windows installs
pnpm-workspace.yaml narrows supportedArchitectures to only win32/x64. pnpm uses this list to decide which platform-specific optional dependencies to install. Running pnpm install on Linux or macOS (the usual local and CI/Cloudflare environments for this repo) will skip the native binaries for packages like esbuild and @parcel/watcher, leading to missing executables or slow source builds and installation failures. Unless the project is meant to run exclusively on Windows, this change makes non‑Windows environments unable to install or build the project.
Useful? React with 👍 / 👎.
1 participant
変更内容
確認事項
pnpm build/pnpm previewが成功