Skip to content

Bump to v1.2.1#19

Merged
ka215 merged 6 commits intomainfrom
dev
Oct 2, 2025
Merged

Bump to v1.2.1#19
ka215 merged 6 commits intomainfrom
dev

Conversation

@ka215
Copy link
Contributor

@ka215 ka215 commented Oct 2, 2025

変更内容

  • ビルド最適化
  • デモユーザーのレイアウト設定の永続化変更

確認事項

  • JSDoc コメントをメソッドに付与済み
  • forEach 使用時はインデックスを利用しているか確認、それ以外は for を利用
  • Lint (Biome) が通過
  • pnpm build / pnpm preview が成功

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +13 to +18
export default defineNuxtPlugin((nuxtApp) => {
for (const [name, loader] of Object.entries(components)) {
nuxtApp.vueApp.component(
name,
defineAsyncComponent({
loader: async () => (await loader()).default,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Register excluded PrimeVue components during SSR

The new plugin registers Dialog, Drawer, DataTable, etc. via defineAsyncComponent, but the file is suffixed with .client.ts and nuxt.config.ts now excludes these components from PrimeVue’s auto-import list. Because ssr remains enabled, the server renderer no longer registers these components and pages that render <Dialog> or <DataTable> outside <ClientOnly> (e.g. components/AccountDeleteModal.vue) will log Failed to resolve component and render empty shells until hydration. Consider registering the components in a shared (client and server) plugin or keep them in the auto-import list so SSR can resolve them.

Useful? React with 👍 / 👎.

@ka215 ka215 merged commit b96e899 into main Oct 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant