Skip to content

Declare vendored spec docs via the new code-scanning excludes input #2354

Description

@magicsunday

What

magicsunday/.github#58 (merged) added a completeness gate to the shared code-scanning reusable workflow: it now fails the job when Semgrep silently skips a file for a reason not on an explicit allow list, instead of uploading a report that understates what was scanned.
This repository's docs/ directory holds vendored specification documents that legitimately exceed Semgrep's 1 MB size limit, so the gate now fails on every run.

Affected files (exceeded_size_limit, verified against the merged gate)

  • docs/DNG_Spec_1_7_1_0.html
  • docs/DNG_Spec_1_7_1_0.pdf
  • docs/EXIF-230.pdf
  • docs/EXIF-231.pdf
  • docs/EXIF-300.html
  • docs/EXIF-300.pdf
  • docs/EXIF-310.html
  • docs/EXIF-310.pdf
  • docs/FPX.html
  • docs/FPX.pdf
  • docs/ICC.html
  • docs/ISO-12234-2.html
  • docs/ISO_IEC_14496-12_2015.html
  • docs/ISO_IEC_14496-12_2015.pdf
  • docs/MPF.html
  • docs/MPF.pdf
  • docs/Quicktime-File-Format-2001.html
  • docs/Quicktime-File-Format-2001.pdf
  • docs/Quicktime-File-Format-2012.html
  • docs/Quicktime-File-Format-2012.pdf
  • docs/TIFF6.html
  • docs/XMP.html

Fix

The reusable workflow added an excludes workflow_call input for exactly this case (a caller-declared list of legitimately-unscannable files, kept separate from .semgrepignore because that file replaces Semgrep's own default ignore list rather than adding to it).
Add a with: excludes: block to the code-scanning job in .github/workflows/security.yml, listing the paths above (space-separated).

Impact until fixed

code-scanning / Semgrep is not a required status check in this repository, so this does not block merges, only shows red on every run.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpriority: lowCosmetic, documentation, or low-traffic-path change with no functional impact

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions