Repository navigation
Conversation
This commit fixes an error in -J where NaN's would be found in b. This was because the orientation (orient) was being used incorrectly and was uninitialized. This caused NaN's to form in b, which was then detected later by the solver. Furthermore, the sensitvity matrix was not correctly being written out as the modelParam readvec/writevec were left empty. This commit makes those routine call the binary versions when called. Later, these can be updated to write out different file types. This issue was reported by Xiaolei (@xltu) in issue magnetotellurics#87 and reported the fix.
MiCurry
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an error in -J where NaN's would be found in b. This was because the orientation (orient) was being used incorrectly and was uninitialized. This caused NaN's to form in b, which was then detected later by the solver.
Furthermore, the sensitvity matrix was not correctly being written out as the modelParam readvec/writevec were left empty. This commit makes those routine call the binary versions when called. Later, these can be updated to write out different file types.
This issue was reported by Xiaolei (@xltu) in issue #87 and reported the fix.