Skip to content

[WIP] Fix error when running -J on main branch due to NaNs in QMR - #92

Closed
MiCurry with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-b-in-qmr-contains-nans
Closed

MiCurry with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-b-in-qmr-contains-nans

Conversation

Copilot AI commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>-J does not work on the main branch ('b in QMR contains NaNs') with MF as of cf9f3d6</issue_title>
<issue_description>Running -J on the main branch results in an error when running the COMPUTE_J task with: b in QMR contains NaNs after the forward is computed. Normally this type of error occurs when an solnVector is not correctly distributed or transferred to a worker task.

Running git bisect I was able to determine that this bug was introduced in cf9f3d6. This error does not happen before that commit, and also does not occur on the classic branch.

I'll spend some time today to determine the cause, but I'm putting this issue here in case I am not able to resolve it quickly.

If this issue is still open, and users need to run -J, they can do so on the classic branch.</issue_description>

Comments on the Issue (you are @copilot in this section)

@MiCurry Doing some digging, by the time we call QMR in ForwardSolver, `eSol` is completely zero. In the classic branch it has a number of values:

Call QMR(b, eSol, KSSiter)

Still haven't found a solution yet, but it looks like eSol is set in the SdivCorr. I might table working on this for now, and focus on finishing up the rest of the EsolnManager and return to this afterwards.

@MiCurry MiCurry closed this Sep 22, 2026
@MiCurry
MiCurry deleted the copilot/fix-b-in-qmr-contains-nans branch September 22, 2026 18:54
Copilot stopped work on behalf of MiCurry due to an error September 22, 2026 18:55
Copilot AI requested a review from MiCurry September 22, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-J does not work on the main branch ('b in QMR contains NaNs') with MF as of cf9f3d6f

2 participants