Repository navigation
Conversation
This issue was raised by Xiaolei (@xltu) and provided a fix for it.
MiCurry
requested review from
akelbert and
dong-hao
and
a lite review from Copilot
September 22, 2026 21:18
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The updated Jmult logic passes the wrong field as the background solution to Lmult/Qmult (and JmultT still pre-allocates eAll_temp in a way that prevents proper initialization).
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
This PR aims to address segmentation faults in the -M/Jmult MPI workflow by ensuring the temporary electric-field container (eAll_temp) is initialized correctly before being used in task distribution and Jacobian-vector products.
Changes:
- Switch
Master_job_Jmultto initializeeAll_tempviaEsMgr_create_solnVectorMTX(..., grid=grid)instead ofcreate_solnVectorMTX. - Update
Master_job_Jmultto useeAll_outin the downstreamLmult/Qmultcalls (intended to avoid referencing an absent optionaleAll).
| File | Description |
|---|---|
| f90/MPI/Main_MPI.f90 | Adjusts Jmult/JmultT solution-vector initialization and updates the fields used in Lmult/Qmult during Jmult. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MiCurry
commented
Sep 22, 2026
| call Lmult(eAll%solns(iper) ,m,eAll_out%solns(iper),d1) | ||
| call Qmult(eAll%solns(iper) ,m,mHat,d2) | ||
| call Lmult(eAll_out%solns(iper) ,m,eAll_out%solns(iper),d1) | ||
| call Qmult(eAll_out%solns(iper) ,m,mHat,d2) |
Member
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was raised by Xiaolei (@xltu) and provided a fix for it in #87
I am not sure if we can use eAll_out in the later on lines 1399 and 1400. @dong-hao or @akelbert do you think this will be okay? I know we can not always guarantee the eAll will be present in this subroutine, but I know we can use either eAll_Temp or eAll_out. I'm just not sure which one to use.