Waterfall policy: make max_task_concurrency optional in rule format - #27
Draft
magniloquency wants to merge 4 commits into
Draft
magniloquency wants to merge 4 commits into
magniloquency wants to merge 4 commits into
Conversation
When omitted from the CSV policy_content, the rule's max_task_concurrency is None and the policy falls back to the value reported by the worker manager heartbeat. An explicit value still acts as a soft cap (min of rule cap and heartbeat cap).
Signed-off-by: magniloquency <197707854+magniloquency@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of finos#833. Base is
main; this PR shows only these changes.Summary
max_task_concurrencyis omitted from the CSVpolicy_content, the rule's field isNoneand the policy falls back to the value reported by the worker manager heartbeat.minof rule cap and heartbeat cap).Test plan
test_waterfall_scaling.pytests passmax_task_concurrencypass: rules with and without the field produce correct concurrency limits