Skip to content

Launchpad: emit max_task_concurrency for ORB EC2 worker manager - #28

Draft
magniloquency wants to merge 1 commit into
waterfall-optional-max-task-concurrencyfrom
orb-ec2-max-task-concurrency
Draft

Launchpad: emit max_task_concurrency for ORB EC2 worker manager#28
magniloquency wants to merge 1 commit into
waterfall-optional-max-task-concurrencyfrom
orb-ec2-max-task-concurrency

Conversation

@magniloquency

@magniloquency magniloquency commented Jun 15, 2026

Copy link
Copy Markdown
Owner

Mirror of finos#834. Base is waterfall-optional-max-task-concurrency; this PR shows only these changes.

Summary

  • Fixes the Launchpad config generator for ORB EC2: without this, max_task_concurrency was not emitted, causing the worker manager to default to os.cpu_count() on the Launchpad host.
  • Derives the count from the cap mode: instance cap directly, or budget divided by instance price.
  • Also fixes configFromToml round-trip: when loading an existing config, the ORB EC2 max_task_concurrency value is now used to populate instanceCap instead of defaulting to 4.

Test plan

  • Generate an ORB EC2 config in the Launchpad and verify max_task_concurrency appears with the correct value
  • Load an existing config with max_task_concurrency set and verify instanceCap round-trips correctly

@magniloquency
Launchpad: emit max_task_concurrency for ORB EC2 worker manager
faa8aa3 
Without this, the field defaulted to os.cpu_count() on the Launchpad
host, causing the worker manager to spin up more instances than configured
and report a higher max concurrency than expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@magniloquency