MT-23076: expose api token expiration in create and reset requests - #253
Draft
oshchyhol wants to merge 6 commits into
Draft
MT-23076: expose api token expiration in create and reset requests#253oshchyhol wants to merge 6 commits into
oshchyhol wants to merge 6 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 7, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MT-23076 – the Mailtrap API token endpoints now accept an optional
expires_atvalue. This exposes it in the .NET SDK.Changes
ApiTokenExpirationtype with a custom JSON converter implementing the tri-state contract: property unset –expires_atkey omitted from the body (server default, a 1-year default is being rolled out behind a feature flag);ApiTokenExpiration.Never– explicit"expires_at": null(token never expires);ApiTokenExpiration.At(...)– ISO 8601 date-time stringCreateApiTokenRequest.ExpiresAtfor thecreateApiTokenoperation (optional nullableexpires_atin the request body)ResetApiTokenRequestand anIApiTokenResource.Reset(ResetApiTokenRequest, CancellationToken)overload for theresetApiTokenoperation, whose request body is now optional; the existing parameterlessReset()keeps sending no bodySpecifier.MaskedToken– the account-accessApiTokenspecifier hasmasked_tokenin the spec, which the SDK model was missingNote: adding a member to
IApiTokenResourceis source-breaking for external implementors of that interface.How to test
client.Account(id).ApiTokens().Create(request)without settingExpiresAt– the request body contains noexpires_atkey; with the server flag enabled the created token gets the default 1-yearexpires_atin the responseExpiresAt = ApiTokenExpiration.Never– the request body contains"expires_at": nulland the response hasexpires_at: nullExpiresAt = ApiTokenExpiration.At(DateTimeOffset.Parse("2027-06-01T00:00:00Z"))– the request body contains the ISO date-time and the response echoes itHttpRequestFailedExceptionwith status 422apiToken.Reset()(parameterless) – the request is sent without a body and succeeds exactly as before this changeapiToken.Reset(new ResetApiTokenRequest { ExpiresAt = ApiTokenExpiration.Never })– the request body is{"expires_at":null}and the new token never expiresexpires_atis returned in responses as beforeCompanion PRs
Caveat: release/merge only after falcon deploys MT-23076 and zap_api_token_expiration is enabled in production.