Skip to content

MT-22678: add search option to ContactLists.List - #26

Merged
Rabsztok merged 1 commit into
mainfrom
MT-22678-contact-lists-search
Jul 17, 2026
Merged

MT-22678: add search option to ContactLists.List#26
Rabsztok merged 1 commit into
mainfrom
MT-22678-contact-lists-search

Conversation

@Rabsztok

@Rabsztok Rabsztok commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Motivation

https://railsware.atlassian.net/browse/MT-22678

Changes

  • Add optional ContactListListOptions{Search} to ContactLists.List — filters lists by name, per the OpenAPI GET /api/contacts/lists param. List(ctx, nil) behaves exactly as before; the param is sent only when set.
    • Breaking signature change (List(ctx)List(ctx, opts)), matching every other filterable list method in the SDK (SuppressionListOptions, MessageListOptions); pre-1.0.

How to test

  • client.ContactLists.List(ctx, nil) — returns all contact lists (unchanged behaviour).
  • client.ContactLists.List(ctx, &mailtrap.ContactListListOptions{Search: "news"}) — returns only lists whose name starts with "news" (case-insensitive).

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Rabsztok, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 05baa961-8d24-4654-804f-88fa54847764

📥 Commits

Reviewing files that changed from the base of the PR and between e7f37fd and 4e5cc02.

📒 Files selected for processing (3)
  • contact_lists.go
  • contact_lists_test.go
  • examples/contact-lists/main.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Decisions:
- opts struct with nil-safe values() mirrors SuppressionListOptions; breaking List signature accepted pre-1.0 as it matches every other filterable list method
- kept the account-less /api/contacts/lists path — routes to the same controller, search applies identically
@Rabsztok
Rabsztok force-pushed the MT-22678-contact-lists-search branch from 7fd6428 to 4e5cc02 Compare July 14, 2026 09:29
@Rabsztok
Rabsztok marked this pull request as ready for review July 14, 2026 12:01
@Rabsztok
Rabsztok requested a review from mklocek July 16, 2026 09:00
@Rabsztok
Rabsztok merged commit e41eb2c into main Jul 17, 2026
4 checks passed
@Rabsztok
Rabsztok deleted the MT-22678-contact-lists-search branch July 17, 2026 05:19
@github-actions github-actions Bot mentioned this pull request Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants