MT-22678: add search option to ContactLists.List - #26
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Decisions: - opts struct with nil-safe values() mirrors SuppressionListOptions; breaking List signature accepted pre-1.0 as it matches every other filterable list method - kept the account-less /api/contacts/lists path — routes to the same controller, search applies identically
7fd6428 to
4e5cc02
Compare
Motivation
https://railsware.atlassian.net/browse/MT-22678
Changes
ContactListListOptions{Search}toContactLists.List— filters lists by name, per the OpenAPIGET /api/contacts/listsparam.List(ctx, nil)behaves exactly as before; the param is sent only when set.List(ctx)→List(ctx, opts)), matching every other filterable list method in the SDK (SuppressionListOptions,MessageListOptions); pre-1.0.How to test
client.ContactLists.List(ctx, nil)— returns all contact lists (unchanged behaviour).client.ContactLists.List(ctx, &mailtrap.ContactListListOptions{Search: "news"})— returns only lists whose name starts with "news" (case-insensitive).