Skip to content

chore: fix lints, update snapshots - #59

Merged
LukeMathWalker merged 1 commit into
mainmatter:mainfrom
MingweiSamuel:cleanup-lints
Feb 8, 2026
Merged

LukeMathWalker merged 1 commit into
mainmatter:mainfrom
MingweiSamuel:cleanup-lints

Conversation

@MingweiSamuel

Copy link
Copy Markdown
Contributor

No description provided.

@MingweiSamuel MingweiSamuel changed the title chore: fix lints chore: fix lints, update snapshots Jan 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses linting issues identified by the Rust compiler and clippy, and updates test snapshots to match current compiler error output formatting.

Changes:

  • Fixed missing lifetime elision annotations in type signatures
  • Removed unnecessary .into_iter() call on a slice that already implements IntoIterator
  • Updated compile-fail test snapshots to reflect current Rust compiler error message formatting

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eserde_derive/src/emit.rs Added explicit lifetime parameter to syn::TypeGenerics return type
eserde/tests/happy/path.rs Removed redundant .into_iter() call (clippy lint fix)
eserde/tests/compile_fail/meta_item_attribute_syntax_bad.stderr Updated error message snapshot with new compiler formatting
eserde/tests/compile_fail/malformed_serde_deserialize_with.stderr Updated error message snapshot with new compiler formatting (indentation changes)
eserde/src/path/path_.rs Added explicit lifetime parameter to Segments iterator return type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LukeMathWalker
LukeMathWalker merged commit 79b3dc8 into mainmatter:main Feb 8, 2026
10 of 11 checks passed
@LukeMathWalker

Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants