Repository navigation
chore: fix lints, update snapshots - #59
Merged
Merged
Conversation
MingweiSamuel
marked this pull request as ready for review
January 23, 2026 06:59
MingweiSamuel
force-pushed
the
cleanup-lints
branch
from
January 23, 2026 06:59
a6f6f02 to
3c66ae1
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses linting issues identified by the Rust compiler and clippy, and updates test snapshots to match current compiler error output formatting.
Changes:
- Fixed missing lifetime elision annotations in type signatures
- Removed unnecessary
.into_iter()call on a slice that already implementsIntoIterator - Updated compile-fail test snapshots to reflect current Rust compiler error message formatting
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
eserde_derive/src/emit.rs |
Added explicit lifetime parameter to syn::TypeGenerics return type |
eserde/tests/happy/path.rs |
Removed redundant .into_iter() call (clippy lint fix) |
eserde/tests/compile_fail/meta_item_attribute_syntax_bad.stderr |
Updated error message snapshot with new compiler formatting |
eserde/tests/compile_fail/malformed_serde_deserialize_with.stderr |
Updated error message snapshot with new compiler formatting (indentation changes) |
eserde/src/path/path_.rs |
Added explicit lifetime parameter to Segments iterator return type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.