Repository navigation
fix(yield): refuse a completion marker that exists before the wait starts - #140
Merged
Merged
Conversation
…arts
Measured live 2026-10-14 (feature 004, phase 4): an adopted regression
chain's yield named an exit_code_file that an earlier job had already left
on disk. The wait ended after 0 s ("yield satisfied ... job rc unknown") and
the next pass was told the job had ended while the chain was still running
and taking the lab down.
A yield whose explicit exit_code_file / file_exists path already exists when
it is accepted is now refused (yield_invalid "completion marker already
exists"), and the agent is told to remove it first, name a fresh path, or
wait on the pid. specstride's own rc file for a launched job is unaffected
(it is removed before launch).
Signed-off-by: mairp <oec.valle.art@gmail.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Merge Queue Status
This pull request spent 8 minutes 43 seconds in the queue, including 7 minutes 56 seconds running CI. Required conditions to merge
|
28 of 36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Measured live 2026-10-14 (feature 004, phase 4): an adopted regression chain's yield named an
exit_code_filethat an earlier job had already left on disk. The wait ended after 0 s ("yield satisfied after 0s (job rc unknown)"), and the next pass was told the job had ended while the chain was still running and taking the lab down.What changes
A yield whose explicit
exit_code_fileorfile_existspath already exists when it is accepted is refused withyield_invalid("completion marker already exists: …"). The agent is told to remove the file first, name a fresh path, or useresume_when.kind: pid. Specstride's own rc file for a launched job is unaffected, because it is removed before launch.Tests
2 new tests in
lib/test_proposer_yield.py: a stale marker is refused, and a fresh marker path still resumes.python -m pytest lib/ -q -n 16: 1289 passed.