Skip to content

Enhancements: Improved potential sorting, component refactor, and data fetching cleanup - #10

Open
Fabio-San wants to merge 1 commit into
maj-rf:mainfrom
Fabio-San:feat/improve-sorting-and-refactor
Open

Fabio-San wants to merge 1 commit into
maj-rf:mainfrom
Fabio-San:feat/improve-sorting-and-refactor

Conversation

@Fabio-San

Copy link
Copy Markdown

Overview Mada by Antigravity

This PR introduces several quality-of-life improvements and architectural cleanups:

Changes Made:

  • Enhanced Sorting Logic: Potentials are now sorted by Priority (Core > Medium > Optional) and then by Selection Order, ensuring a consistent and predictable UI.
  • Component Refactoring: Extracted the SingleSelected logic into a dedicated component in src/components/single-selected.tsx for better maintainability.
  • Clean Data Fetching: Decoupled store side-effects from the character fetching utility. Data initialization is now handled explicitly in the route loader.
  • Centralized Config: Moved the character data URL to a new src/config.ts file.
  • Added Unit Tests: Included src/tests/sorting.test.ts to verify the new sorting logic.

These changes should make the codebase easier to scale and improve the user experience when building teams.

@vercel

vercel Bot commented Dec 19, 2025

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the personal_maj-rf Team on Vercel.

A member of the Team first needs to authorize it.

@Fabio-San

Copy link
Copy Markdown
Author

Feel free to consider it or refuse, of course! I was free and asked Antigravity if I could improve your amazing website!

@maj-rf

maj-rf commented Jan 6, 2026

Copy link
Copy Markdown
Owner

Overview Mada by Antigravity

This PR introduces several quality-of-life improvements and architectural cleanups:

Changes Made:

  • Enhanced Sorting Logic: Potentials are now sorted by Priority (Core > Medium > Optional) and then by Selection Order, ensuring a consistent and predictable UI.
  • Component Refactoring: Extracted the SingleSelected logic into a dedicated component in src/components/single-selected.tsx for better maintainability.
  • Clean Data Fetching: Decoupled store side-effects from the character fetching utility. Data initialization is now handled explicitly in the route loader.
  • Centralized Config: Moved the character data URL to a new src/config.ts file.
  • Added Unit Tests: Included src/tests/sorting.test.ts to verify the new sorting logic.

These changes should make the codebase easier to scale and improve the user experience when building teams.

Sorry about not seeing this soon. The tests and the sorting logic are really good! Will look into these changes in the future. I'll keep this open. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants