Skip to content

chore(skill): resync pdf-template-author.md from the monorepo (MAK-229) - #3

Merged
lecstor merged 2 commits into
mainfrom
clanker/8cb1ff06-sync-the-pdf-template-author-skill-snaps
Oct 27, 2026
Merged

lecstor merged 2 commits into
mainfrom
clanker/8cb1ff06-sync-the-pdf-template-author-skill-snaps

Conversation

@lecstor

@lecstor lecstor commented Oct 27, 2026

Copy link
Copy Markdown
Member

What

Refreshes the CLI's baked snapshot of skills/pdf-template-author.md from the monorepo (lecstor/makespdf main at a650ab6b), so makespdf skill emits the current canonical file. The old snapshot dated from 4a98dfe and had drifted by +250/−55 lines (MAK-226 page-number options, report_feedback, § Script shape, the lang option, the profile default-font paragraph, and smaller prose edits).

No code changes: scripts/bake-skill.mjs regenerates src/embedded-skill.ts (gitignored) from the markdown at build time. A patch changeset (.changeset/skill-resync-page-numbers.md) is included so the refreshed skill reaches npm consumers.

Round-1 review fixes

  • CI now pins the baked output to the snapshot byte for byte (.github/workflows/ci.yml smoke step: cmp skills/pdf-template-author.md /tmp/skill.md), so a bake-skill.mjs regression fails CI instead of shipping silently.
  • The changeset no longer repeats the "const-only" script-shape claim.
  • Four content defects in the canonical upstream file (the if-statement contradiction, Step 6's .dsl examples, the bare lang link) are filed as MAK-305 (repo lecstor/makespdf, ready) rather than hand-edited in the CLI copy, whose whole point is byte-equality with upstream. If MAK-305 lands first, this snapshot should be re-copied before merge; otherwise merge this and let MAK-305 re-copy afterwards.

Verification

  • pnpm build exit 0 (bake-skill 96407 chars; dist/index.js 122.34 KB).
  • CI smoke step run verbatim: --help exit 0, skill exit 0, cmp green — sha256 217cf13a2432cb20db35199ab5526b2f5af9ec9a0298b94ef698fe39b55de02b on both sides.
  • pnpm typecheck exit 0; pnpm test 22/22 (4 files); pnpm exec changeset status → @makespdf/cli patch.
  • Upstream lecstor/makespdf main (a650ab6b27bb80b7fe3394a9212947c8d12f7781) carries the same file sha256.

Snapshot of the canonical `skills/pdf-template-author.md`, which the CLI
bakes in at build time for `makespdf skill`. The copy in this repo dated
from 4a98dfe and had drifted by 250 added / 55 removed lines.

Most notably it now carries the markdown page-number paragraph from
MAK-226 (`pageNumbers` / `pageNumberPosition`, including the YAML
frontmatter form), plus the `report_feedback` MCP tool, the script-shape
rules, the `lang` document option, the profile default font guidance and
the chart() note.

No code changes: scripts/bake-skill.mjs regenerates src/embedded-skill.ts
from this file on every prebuild/pretypecheck/pretest hook.
MAK-229 ships a refreshed skills/pdf-template-author.md. The review noted
the CI smoke step only asserted the emitted skill was non-empty, so a
bake-skill.mjs regression (transform, truncation, re-escaping) would ship
silently — the same staleness this task exists to clear has already
recurred twice (735c769 -> 4a98dfe -> this resync). `cmp` the emitted file
against the markdown: bake-skill.mjs embeds it verbatim, so the bytes are
identical today and any future drift fails the build.

Also drop the "`const`-only" claim from the changeset: the canonical file's
Script shape section contradicts its own DSL Traps bullet on `if`
statements and `let`, and that inaccuracy should not be republished in the
CHANGELOG. The canonical-file correction is filed upstream as MAK-305; this
diff cannot touch it because the copy must stay byte-identical.
@lecstor
lecstor merged commit 3a11dbc into main Oct 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant