Repository navigation
chore(skill): resync pdf-template-author.md from the monorepo (MAK-229) - #3
Merged
lecstor merged 2 commits intoOct 27, 2026
Merged
Conversation
Snapshot of the canonical `skills/pdf-template-author.md`, which the CLI bakes in at build time for `makespdf skill`. The copy in this repo dated from 4a98dfe and had drifted by 250 added / 55 removed lines. Most notably it now carries the markdown page-number paragraph from MAK-226 (`pageNumbers` / `pageNumberPosition`, including the YAML frontmatter form), plus the `report_feedback` MCP tool, the script-shape rules, the `lang` document option, the profile default font guidance and the chart() note. No code changes: scripts/bake-skill.mjs regenerates src/embedded-skill.ts from this file on every prebuild/pretypecheck/pretest hook.
MAK-229 ships a refreshed skills/pdf-template-author.md. The review noted the CI smoke step only asserted the emitted skill was non-empty, so a bake-skill.mjs regression (transform, truncation, re-escaping) would ship silently — the same staleness this task exists to clear has already recurred twice (735c769 -> 4a98dfe -> this resync). `cmp` the emitted file against the markdown: bake-skill.mjs embeds it verbatim, so the bytes are identical today and any future drift fails the build. Also drop the "`const`-only" claim from the changeset: the canonical file's Script shape section contradicts its own DSL Traps bullet on `if` statements and `let`, and that inaccuracy should not be republished in the CHANGELOG. The canonical-file correction is filed upstream as MAK-305; this diff cannot touch it because the copy must stay byte-identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refreshes the CLI's baked snapshot of
skills/pdf-template-author.mdfrom the monorepo (lecstor/makespdfmainata650ab6b), somakespdf skillemits the current canonical file. The old snapshot dated from4a98dfeand had drifted by +250/−55 lines (MAK-226 page-number options,report_feedback, § Script shape, thelangoption, the profile default-font paragraph, and smaller prose edits).No code changes:
scripts/bake-skill.mjsregeneratessrc/embedded-skill.ts(gitignored) from the markdown at build time. A patch changeset (.changeset/skill-resync-page-numbers.md) is included so the refreshed skill reaches npm consumers.Round-1 review fixes
.github/workflows/ci.ymlsmoke step:cmp skills/pdf-template-author.md /tmp/skill.md), so abake-skill.mjsregression fails CI instead of shipping silently.const-only" script-shape claim.if-statement contradiction, Step 6's.dslexamples, the barelanglink) are filed as MAK-305 (repolecstor/makespdf, ready) rather than hand-edited in the CLI copy, whose whole point is byte-equality with upstream. If MAK-305 lands first, this snapshot should be re-copied before merge; otherwise merge this and let MAK-305 re-copy afterwards.Verification
pnpm buildexit 0 (bake-skill96407 chars;dist/index.js122.34 KB).--helpexit 0,skillexit 0,cmpgreen — sha256217cf13a2432cb20db35199ab5526b2f5af9ec9a0298b94ef698fe39b55de02bon both sides.pnpm typecheckexit 0;pnpm test22/22 (4 files);pnpm exec changeset status→@makespdf/clipatch.lecstor/makespdfmain(a650ab6b27bb80b7fe3394a9212947c8d12f7781) carries the same file sha256.