Repository navigation
chore(skill): sync pdf-template-author snapshot with table cell guidance - #5
Merged
Merged
Conversation
Stops teaching cell classes on cell content, which applies a cell's padding and border twice. Matches lecstor/makespdf#410.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The skill told authors to extend
.table-headerand put the class on a span inside the cell.table(),th()andtd()already add that class to the cell, so its padding and border applied twice. Repeating the exact class also produced a nestedTHthat failed PDF/UA-1 rule 7.2-8.What changed
skills/pdf-template-author.mdis copied from the monorepo branch for lecstor/makespdf#410:These are the only differences from the previous snapshot. That monorepo PR isn't merged yet, so the snapshot will match the monorepo's
integrationbranch once it is.Testing
Text-only change to the baked skill. I didn't run the CLI's build or tests locally. CI runs on this PR.
No changeset, matching the earlier resync PRs, so this reaches users with the next CLI release.