Repository navigation
fix(cli): report the package version from --version - #6
Merged
Merged
Conversation
The version was hardcoded as 0.1.0 in the first scaffold and never updated. Read it from package.json like the client header does. The command definition moves out of index.ts so a test can import it without running the CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
makespdf --versionalways printed0.1.0. The value was hardcoded in the first scaffold and never updated, so0.2.1reports the wrong version.What changed
--versionnow usesCLIENT_VERSIONfromclient-info.ts, which readspackage.json. TheX-MakesPDF-Clientheader already used it.src/index.tstosrc/main.ts, so a test can import it without running the CLI.index.tsnow only callsrunMain.Testing
src/main.test.tsfails against the old value (expected '0.1.0' to be '0.2.1') and passes with the fix.pnpm test(23 tests) andpnpm buildpass locally.0.2.1for--version, andskilland--helpstill work.