refactor: consolidate shared types and add oxfmt formatting - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes bundled on this branch (as agreed):
src/types.tsand tighten encapsulation (export→ module-private) insrc/domain/post-comments.ts.oxfmtas a dev dependency and format the codebase with it.What's included
Refactor (existing commits)
refactor: consolidate shared types in types.ts and tighten encapsulation(9aa0f9c)refactor: centralize GitHub review DTOs and inline-finding type in types.ts(5105be2)Formatting (
03809de)oxfmt ^0.62.0to devDependencies (package.json,pnpm-lock.yaml)oxfmt.config.tsmatching the existing codebase style:singleQuote: trueprintWidth: 120sortImports: falseignorePatterns: ['.vendor/**'](protects the vendored submodule)pnpm typecheck / lint / format / test) in the READMEVerification
pnpm typecheck✅pnpm test— 191/191 pass ✅pnpm lint✅oxfmt --check✅