Conversation
|
@ANISH-SR The e2e test is failing: could you take a look? It seems the change may leave the interface in an invalid state. Thanks. |
|
Hi @juan-malbeclabs , I looked into the e2e failure and it seems to be quite a hassle here. if this change is not immediately needed, I'll go ahead and draft this for now. Rest assured, I'll recommit with some unit tests for the change. Thanks a ton :) |
|
@ANISH-SR Hi, lmk how this goes. We would like to finish there Ottersec issues soonish. |
I have added integration tests here. Can confirm all the local checks passing! Can you review it @martinsander00 , thanks |
|
fixed the merge conflict |
|
@ANISH-SR looks like there are still tests and linting errors |
Summary of Changes
Testing Verification
Closes #2230