Skip to content

Properly fix MIDI loop timing at end of record, including overdubs#108

Merged
malisimat merged 1 commit into
masterfrom
bugfix/midi-timing
Jun 8, 2026
Merged

Properly fix MIDI loop timing at end of record, including overdubs#108
malisimat merged 1 commit into
masterfrom
bugfix/midi-timing

Conversation

@malisimat

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 7, 2026 23:13
@malisimat malisimat self-assigned this Jun 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how MIDI loop playback/overdub timing is anchored when transitioning out of record/overdub, aiming to make end-of-record MIDI timing consistent (including overdubs) by basing MIDI phase on trigger/quantisation timing rather than audio play position.

Changes:

  • Pass MIDI quantisation error into LoopTake::Play() and use it to set the initial MIDI visual/play index.
  • Rework MIDI overdub merge to rebase source MIDI events relative to the captured source start sample (and stop shifting punch windows/events by a phase offset).
  • Update existing MIDI timing assertions and add a regression test covering double-length overdubs with non-zero audio play positions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
test/JammaLib_Tests/src/midi/MidiLoop_Tests.cpp Updates expectations for overdub/playback timing and adds a regression test for “no punch, double-length” overdub timing.
JammaLib/src/engine/Station.cpp Threads quantisation error (errorSamps) into LoopTake::Play() at record/overdub end triggers.
JammaLib/src/engine/LoopTake.h Extends LoopTake::Play() signature with optional midiQuantisationErrorSamps; updates helper signature to remove phase-offset argument.
JammaLib/src/engine/LoopTake.cpp Implements new MIDI start index logic and rebased-source overdub merge behavior (including additional verbose diagnostics).

Comment on lines +2286 to +2289
std::array<midi::MidiEvent, midi::MidiLoop::DefaultCapacity> rebasedSourceEvents{};
const auto rebasedSourceCount = BuildRebasedMidiOverdubSourceEvents(state,
rebasedSourceEvents.data(),
rebasedSourceEvents.size());
@malisimat malisimat merged commit 219b0a3 into master Jun 8, 2026
1 check passed
@malisimat malisimat deleted the bugfix/midi-timing branch June 8, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants