Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes macOS native packaging in CI by improving path resolution and validation logic. The changes ensure that the macOS native binary is properly located and included in packages during CI builds.
- Improved path resolution using MSBuild functions to locate native binaries reliably across different environments
- Enhanced CI logging to show which native binary is being packed
- Hardened package validation to inspect all produced packages and fail if any lack the native library
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/MLXSharp/MLXSharp.csproj | Updated path resolution to use MSBuild functions for reliable cross-platform path handling |
| .github/workflows/ci.yml | Enhanced CI pack steps with explicit logging and improved package validation logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68e229d761248326b7098a2b8b83fdc3