refactor(config parsing): changed from if/elif chain to precalculated hash table with a switch case and added caching of keysyms#837
Open
DuckTapeMan35 wants to merge 1 commit intomangowm:mainfrom
Conversation
…hash table with switch case and added caching of keysyms this refactor marginally speeds up config parsing by targetting the 2 biggest bottlenecks, namely iterating over keysyms every time and using extremely long if/elif chains. benchmarking each command with 1000 runs: /home/duck/mango/build/mango -p (the code in this PR) Average: 4.88 ms (std dev: 1.08 ms) mango -p Average: 5.31 ms (std dev: 1.01 ms) about 1.09x faster this PR does somewhat make it harder to add new functions/options in that they need to be added to both parse_config.h in the switch case and in the appropriate .gperf file. that being said the improvements would get more noticeable as mango adds more options to its configuration. as for readability, I believe a switch case is more readable.
Collaborator
|
So is this just a few milliseconds faster? I'm not quite sure if it's worth it, because it introduces new dependencies. |
Author
|
Yes. I wasn't sure if I should make a PR because it's not a very big improvement, but I did anyway to let you decide |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this refactor marginally speeds up config parsing by targetting the 2 biggest bottlenecks, namely iterating over keysyms every time and using extremely long if/elif chains.
benchmarking each command with 1000 runs:
/home/duck/mango/build/mango -p (the code in this PR)
Average: 4.88 ms (std dev: 1.08 ms)
mango -p
Average: 5.31 ms (std dev: 1.01 ms)
about 1.09x faster
this PR does somewhat make it harder to add new functions/options in that they need to be added to both parse_config.h in the switch case and in the appropriate .gperf file.
that being said the improvements would get more noticeable as mango adds more options to its configuration.
as for readability, I believe a switch case is more readable.