Repository navigation
fix(security): drop fake demo password and ignore real .env files - #1
Merged
Merged
Conversation
demo/.env is a committed fixture for `envguard scan demo`, but it shipped SMTP_PASSWORD=hunter2. Replace that with an empty placeholder (which also surfaces the EMPTY finding) and ignore real .env files everywhere else. Co-authored-by: manijose1919 <manijose1919@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnvGuard's demo project has to keep a committed
.envsoenvguard scan demoand CI can reproduce planted drift. That file previously usedSMTP_PASSWORD=hunter2, which secret scanners treat as a credential and which models a bad habit.Changes
.env/.env.*files, with an explicit exception for the demo fixture and*.env.example.demo/.envis a placeholder, not a secret.22 tests pass; the demo scan still exits 1 on planted drift as CI requires.