Feature/highscores 4#66
Conversation
…remote submissions
…rsioning in user options
…d satellite connection indicator for high scores
…r better layout handling
…or improved organization and clarity
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cae92def3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const getHighScoreApiCandidates = (): string[] => { | ||
| const urls = new Set<string>([getHighScoreApiUrl(), defaultHighScoreApiUrl]); | ||
|
|
||
| for (let offset = 0; offset < apiPortScanAttempts; offset += 1) { | ||
| urls.add(`http://localhost:${apiPortScanStart + offset}`); | ||
| } |
There was a problem hiding this comment.
The new proxy fallback scans http://localhost:8787..8806 and accepts the first response that is merely non-404 JSON, so any unrelated local JSON service on those ports can be treated as the high-score API. In that setup, score submissions (POST /api/high-scores) and run receipt requests can be sent to the wrong process, causing incorrect sync behavior and possible local data leakage during development. The candidate selection needs stronger validation (or no broad port scan) so only the intended high-score server is eligible.
Useful? React with 👍 / 👎.
1 participant
This pull request introduces several new features and improvements focused on high-score tracking, Storybook integration, touch controls, and improved user feedback. The most significant changes include adding a satellite connection indicator for high-score sync state, enabling the touch steering guide by default, publishing a production Storybook reference site (including a new sprite gallery), and ensuring debug-mode runs are kept local-only for high scores. The update also improves migration and persistence of user options and enhances test coverage for these behaviors.
High Score System Improvements
Storybook Integration
/stories/, built and published as part of the main build process. The showcase page now links to this route for sprite, menu, preroll, achievement, audio, and UI reference views. [1] [2] [3] [4] [5] [6]Touch Controls and User Options
Documentation and Release Notes
README.mdandWHATSNEW.mdto document all new features, changes to the high-score system, Storybook integration, and touch controls. [1] [2] [3] [4] [5] [6] [7] [8]Build Process
These changes improve user experience, increase feature visibility, and ensure high-score integrity and transparency, especially for offline and debug scenarios.