Feature/engine separation

[manix84]

This pull request introduces significant refactoring and improvements to the sound engine, debug vector rendering, and module import structure, along with corresponding updates to tests and code organization. The main goals are to make the sound engine more configurable and decoupled from game settings, enhance testability, and ensure clear separation of concerns between engine and game modules.

Sound Engine Refactor and Improvements:

• Refactored the Sound class to accept configuration via a new Sound.configure() method, allowing consumers to provide volume calculation logic, event hooks (e.g., for playback blocking), and event-driven volume updates, instead of directly depending on userOptions. [1] [2] [3] [4] [5] [6]
• Updated all sound engine consumers to import Sound and helpers from the new engine barrel file, improving modularity and enforcing separation between engine and game modules. [1] [2] [3] [4] [5] [6] [7] [8]

Debug Vectors Refactor:

• Moved core debug vector logic into the engine and updated drawDebugVectors in the game layer to delegate to the engine implementation, allowing for customizable colors and improved testability. [1] [2]
• Enhanced engine tests to verify correct debug vector rendering, including color and drawing behavior. [1] [2]

Module Import Structure and Enforcement:

• Added a test to ensure production engine modules do not import from game modules, enforcing a clean dependency direction. [1] [2]

Testing and Configuration Updates:

• Refactored engine tests to use the new Sound.configure() API, replacing direct userOptions mutation with test-local configuration and event dispatching. Added tests for sound playback blocking notification and correct volume calculation. [1] [2] [3] [4] [5] [6]

Other Maintenance:

• Updated the project version in package.json to 29.0.0.
• Fixed type import paths in engine modules for consistency.

These changes collectively improve modularity, maintainability, and testability of the codebase, especially around the sound engine and debug tooling.

[Copilot]

Pull request overview

This PR refactors the game engine toward a more modular “engine vs. game” separation by centralizing shared engine types, introducing an engine barrel export, and decoupling the sound system from direct userOptions dependencies to improve configurability and testability.

Changes:

• Centralized shared engine type definitions into src/game/engine/types.ts and re-exported them for backwards compatibility via src/game/types.ts.
• Introduced src/game/engine/index.ts as a unified entry point and updated game modules to import engine components from it.
• Refactored Sound to use injected configuration (SoundEngineConfiguration) for volume and option-change notifications; expanded GameArena to accept configurable rendering/font options.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/game/types.ts	Re-exports shared engine types from the new centralized engine types module.
src/game/systems/spawning.ts	Switches sound import to the new engine entry point.
src/game/player.ts	Switches sound import to the new engine entry point.
src/game/index.ts	Configures the sound engine via Sound.configure() and passes GameArenaOptions when constructing the arena.
src/game/engine/types.ts	Adds centralized engine type definitions (coords, sprites, arena options, ticker, sound config/types).
src/game/engine/Ticker.ts	Updates type import to come from ./types.
src/game/engine/Sound.ts	Refactors sound volume/event wiring to use injected configuration and adds playback-blocked callback support.
src/game/engine/index.ts	Adds engine barrel exports for core engine modules and shared engine types.
src/game/engine/helpers.ts	Updates type import to come from ./types.
src/game/engine/arena.ts	Adds configurable GameArenaOptions (font/colors/grid) and removes direct palette/asset dependencies.
src/game/engine/tests/engine.test.ts	Updates tests to configure Sound via the new configuration API rather than mutating userOptions.
src/game/enemy.ts	Switches sound import to the new engine entry point.
src/game/bullet.ts	Switches sound import to the new engine entry point.
src/game/bullet-factory.ts	Switches sound import to the new engine entry point.
package.json	Bumps package version to 28.1.0.
package-lock.json	Updates lockfile versions to 28.1.0.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 27 out of 28 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 27 out of 28 changed files in this pull request and generated 2 comments.