Fixing bug in transfer function (>= vs. >)#463
Open
BenHafner wants to merge 2 commits intomanoharan-lab:developfrom
Open
Fixing bug in transfer function (>= vs. >)#463BenHafner wants to merge 2 commits intomanoharan-lab:developfrom
BenHafner wants to merge 2 commits intomanoharan-lab:developfrom
Conversation
Changed mask function from (root >= 0) to (root > 0) so it returns False when root = 0. (A few lines earlier, root was set to zero at frequencies greater than 1/wavelength, which we're trying to mask out because they aren't realistic, so the mask function should return False when root = 0)
Update convolution_propagation.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed g = g*(root >= 0) to g = g*(root > 0). The point of this line is to mask out the spatial frequencies greater than 1/wavelength, which don't make sense physically. These are the frequencies where root is negative. But a few lines earlier there was this line: root *= (root >= 0) which already turned all the negative values of root into zero. So multiplying g by (root > 0) instead of (root >= 0) is required to properly mask out the points where root = 0 (the points where root was originally negative).
I can work on also writing a test function to check if there are any other issues with reconstruction, but for now I just changed that one line.