Repository navigation
test(trie): verify sparse trie updates in PR CI - #262
Merged
Merged
Conversation
bruce-sihua
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sparse trie arena regression compared the return values of
Vec::sort(). Both sides were(), so incorrect updated or removed nodes could pass as long as the storage root matched.Restore the assertion change from paradigmxyz#26842: sort the expected and actual node lists, then compare their contents. Add
cargo test -p reth-trie-sparse --test '*'to the PR gate so existing and future integration targets are selected without rerunning the library tests.Verification
just prpassed, including Clippy, workspace and integration tests, and all-features doctests.updated nodes mismatchandremoved nodes mismatchassertions. Both changes were reverted and the tests passed again.