Skip to content

test(trie): verify sparse trie updates in PR CI - #262

Merged
ivanwang-coder merged 1 commit into
dev/mantle-v1.7.0from
fix/v170-sparse-trie-ci
Nov 19, 2026
Merged

ivanwang-coder merged 1 commit into
dev/mantle-v1.7.0from
fix/v170-sparse-trie-ci

Conversation

@ivanwang-coder

Copy link
Copy Markdown

The sparse trie arena regression compared the return values of Vec::sort(). Both sides were (), so incorrect updated or removed nodes could pass as long as the storage root matched.

Restore the assertion change from paradigmxyz#26842: sort the expected and actual node lists, then compare their contents. Add cargo test -p reth-trie-sparse --test '*' to the PR gate so existing and future integration targets are selected without rerunning the library tests.

Verification

  • Full local just pr passed, including Clippy, workspace and integration tests, and all-features doctests.
  • The sparse trie suite passed 16 unit tests and 192 integration tests. The existing memory-size benchmark test remains ignored by default.
  • Temporarily removed one expected update and one expected removal in separate runs. The arena property test failed with the respective updated nodes mismatch and removed nodes mismatch assertions. Both changes were reverted and the tests passed again.

@ivanwang-coder
ivanwang-coder merged commit d01fca2 into dev/mantle-v1.7.0 Nov 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants