Repository navigation
test(tasks): fix flaky worker idle assertion - #264
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
worker_map_try_spawn_busyseen in the release PR #236 CI job. The worker sends the result before decrementing its pending count, so the immediate resubmission can still see it as busy.Verification
worker should be idlelocally before the patch. The patched test passed 100 consecutive runs, and all 55reth-taskstests passed with all features enabled.just test-cipassed. Nextest reported 380 passed and 3 skipped.just clippy, andjust test-docpassed.