Repository navigation
fix(cli): reject flashblock consumers with local transaction retention - #266
Merged
adam-xu-mantle merged 1 commit intoNov 20, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A forwarding RPC node can retain submitted transactions in its local pool while a flashblock consumer supplies the pending state. Transactions present only in the local pool can then produce misleading pending responses alongside the consumed flashblocks.
Reject
--rollup.retain-forwarded-txstogether with either consumer duringMantleArgs::into_configs, before services and the node are started:--flashblocks.websocket-url, including--subblocks.websocket-url.--flashblocks-url, including--websocket-url.The startup error names the conflicting parameters, explains the pending-state mismatch, and directs operators to disable local retention. Reject the combination even when
--rollup.sequenceris currently absent, so the configuration remains unambiguous. Each feature remains valid when configured alone.Deployments using a consumer must omit
--rollup.retain-forwarded-txsbefore upgrading. This PR is independent of the slice-maintenance changes in #265.Test plan
just prpassed locally: fmt, clippy, workspace tests, version checks, 380 node integration tests, sparse-trie integration tests, and default/all-feature doctests. Three node integration tests were skipped; nextest marked four passing tests asLEAK.